Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Member detail view page to the application. It introduces a new route and view component for displaying member information, including their contact details, speakers they're associated with, companies they work with, and their participation history across events and teams. The autocomplete search functionality is also enhanced to support member searches alongside companies and speakers.
- New member detail page with comprehensive member information display
- Enhanced search autocomplete to include members
- Added navigation links to member pages from speaker and company member lists
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
frontend/src/views/Dashboard/Members/MemberView.vue |
New view component displaying member details, participations, associated speakers and companies |
frontend/src/router.ts |
Added route configuration for the member detail page |
frontend/src/components/CompanyOrSpeakerOrMemberAutocompleteWithDialog.vue |
Renamed from CompanyOrSpeakerAutocompleteWithDialog and extended to support member search |
frontend/src/components/Navbar.vue |
Updated to use renamed autocomplete component and handle member selection |
frontend/src/components/speakers/MembersSpeakers.vue |
Wrapped member display with RouterLink for navigation to member page |
frontend/src/components/companies/MembersCompanies.vue |
Wrapped member display with RouterLink for navigation to member page |
frontend/src/api/members.ts |
Added API functions for fetching member details and participations |
Comments suppressed due to low confidence (4)
frontend/src/components/CompanyOrSpeakerOrMemberAutocompleteWithDialog.vue:455
- The
getItemIndexfunction may return incorrect results when companies, speakers, and members have overlapping IDs. Since items of different types can have the same ID, the function should also compare the type property to ensure it finds the correct item.
frontend/src/components/CompanyOrSpeakerOrMemberAutocompleteWithDialog.vue:450 - The results computed property creates new objects for all items on every computation. Consider memoizing or adding the type property only when needed to avoid unnecessary object creation on each reactive update.
frontend/src/components/CompanyOrSpeakerOrMemberAutocompleteWithDialog.vue:521 - The type checking now uses the
typeproperty added in the results array, but this approach requires type assertions. The previous approach using'companyName' in selectedResult'was a type guard. Consider defining a discriminated union type with explicit type fields in the DTO definitions instead of adding type properties at runtime.
frontend/src/components/CompanyOrSpeakerOrMemberAutocompleteWithDialog.vue:469 - The comment states 'Member may have an
imgproperty' but doesn't explain when this property might be missing or what the fallback behavior is. Consider clarifying the expected behavior or adding a fallback value when the property is undefined.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #513.